Denis Žoljom

Results 366 comments of Denis Žoljom
trafficstars

> Just had a quick look: this change was made in WP 6.3, so will need a minimum WP based toggle. Additionally, what with `$args` being an array, this will...

I never saw a make post about discouraging 'long' closures to be honest, and since we should always create make posts for these kinds of things, I'd be willing to...

I think that the name of the issue should be renamed to `Discourage lambda callbacks in add_filter() and add_action()` instead of `"Ban"...` 🙂 Just to avoid the confusion, as I...

> The fact that the API isn't currently designed with these in mind means that the API needs to be updated to take these into account. As long as WordPress...

I personally would be against this (adding `add_action/add_filter` in the constructor). Just looks like a problem in the long run (tight coupling to class, difficult to test, a problem when...

Knew there must be edge cases I missed 😅 I'll work on this some more in the following days, I need to get some sleep 🙈

@jrfnl The tests seem to be passing now, only the 2 seem to be stalling (or just taking an unusually long time).

Any chance we can move this PR along?

We can't just add the token as a secret in the repo, and use it in the action?

I've just now realized that this helper is kinda doing too much on its own than its name suggests. The helper says it will _merge_ the custom array, but can...