Denis Žoljom

Results 366 comments of Denis Žoljom
trafficstars

Not sure why this fails, but I've successfully mocked and tested other methods, and the hooks seem to be green (covered). 🤷‍♂️

The `WP_Mock` is the remnant from old tests, where I had to figure out how to mock stuff (and in the process of writing tests I realized how tightly I...

Hi @gmazzap! Thanks for the extensive answer. I know that I could teardown the internal redefinition after each test, but I think why I made this because I needed to...

Yes, partially. Some proposals had comments that will be addressed in the subsequent make posts. You can check the sheet with the parts that will go into the WPCS and...

What do you expect to happen for the above example? It's hard to check without info about what is the desired behavior 🤷🏼‍♂️ Please open a new issue to discuss...

Did you try using `develop` branch of WPCS and see if the import use statements part would cover what you asked? https://developer.wordpress.org/coding-standards/wordpress-coding-standards/php/#declare-statements-namespace-and-import-statements

@janw-me can you check with the `dev-hotifx/escape-output-sniff` branch and see if it will work? I think it should be fixed with the #2370

I'll probably take a look tomorrow. Maybe there's something in the sniff I need to modify to take the static methods into account.

I think I found the issue and will try to see how to solve it in my PR, I just need to get feedback from the rest of the maintainers...

@janw-me I've updated the branch with some modifications, can you test it? You should be able to pass the static methods with their respective classes now in the `customEscapingFunctions` property....