Denis Žoljom

Results 369 comments of Denis Žoljom
trafficstars

Theme Check runs on theme upload, while Theme Sniffer is a recommended tool that will run PHP_CodeSniffer against your theme. It's a help for theme authors and reviewers to check...

Seems doable. Just one thing that's a bit worrisome to me is if we want to use theme sniffer on wordpress.org site (like a stand in for current theme check),...

Was this implemented or does a PR exist for this?

Sounds interesting but I'm not sure how would this be done tbh. We should have to list all the rules from the ruleset, make them toggle-able and based on the...

This sounds like it could be covered by this: https://github.com/WPTRT/WPThemeReview/issues/174 Love the initiative and the explanation for this issue :+1:

#124 PR is opened for this

We sniff css and js as well, and I have a safeguard to exclude minified files which will prevent these fatal errors. If you check out the version from the...

I agree, I'll see if I can implement JS and CSS checking using `eslint` and `stylelint` using WordPress standards. That way I should probably avoid memory issues. Thanks!

I've given some thought about linting JS and (S)CSS using `eslint` and `stylelint`, and I don't think this will be possible, as I cannot know if a user has (in...

You mean the css in the customizer? I'd have to look into that, never poked around that part of the core 😄