Dinesh B

Results 48 comments of Dinesh B

Could you give small example and some details about your usecase?

Looks the formula is [up to date.](https://github.com/Homebrew/homebrew-core/blob/master/Formula/talisman.rb) We can close this issue @harinee @svishwanath-tw May be we can add about brew installation method in readme

Created seperate issue to track the performance https://github.com/thoughtworks/talisman/issues/152. We can use this issue to track the `showing progress`

Added test for scanner method which is getting panic... Able to **reproduce the same error only if we change TAB to spaces** in https://github.com/thoughtworks/talisman/blob/test-for-scanner/scanner/scanner_test.go#L12-L13... Same error `panic: runtime error: index...

@en0 changes look good to me. Let me try to run this commands once before merging. I will do it within 2 days. Thanks for the PR 😀👍🏻

@en0 Sorry for the delay... These are the last set of feedback: 1. typo: `findeploy` -> `finddeploy` (d missing) 2. install.sh is not working in mac error: ``` find: -executable:...

@en0 Please fix the `install.sh` alone... Others we can fix after merging this PR...

Can we automate the `Release + Changelog` creation step ? like [code](https://github.com/thecasualcoder/tztail/blob/master/.travis.yml#L36-L42) and [example](https://github.com/thecasualcoder/tztail/releases)?

@rbuck-som Are you still facing this issue ? Can you test once with appRole using vault command line ? [Try to login like here](https://www.vaultproject.io/docs/auth/approle#via-the-cli) using your roleId and secretId. Then...

Need some suggestion on the aws client [nonce](https://www.vaultproject.io/docs/auth/aws#client-nonce) Can we capture nonce as the secret in the credentials panel ? Currently it is hardcoded as string `nonce` in the code....