Dymitr (Dmitry) Paremski

Results 18 comments of Dymitr (Dmitry) Paremski

Some clarifications after talking to @lukasz-zimnoch > If the list is properly formed in case there are misbehaviors during DKG We already have unit tests that check this https://github.com/keep-network/keep-core/blob/main/pkg/beacon/dkg/dkg_test.go#L163 Also,...

> adding interactive prompts in install.sh and initialize.sh scripts to ask the developer for the required parameters (we've got prompts already in start.sh) Just to clarify, do you have in...

After discussing improvements with @nkuba we decided to add only reading the address from the `ethereum.keyFile`. Regarding the other params, we think, that prompting for config params in `install.sh` is...

When running `/scripts/start.sh` or manually `./keep-client --config /Users/dp/go/src/github.com/keep-network/keep-core/configs/config.toml` shows the following error: ``` 2022-08-30T12:06:47.592+0200 FATAL keep-main keep-core/main.go:51 unknown flag: --config ```

> ./keep-client --config /Users/dp/go/src/github.com/keep-network/keep-core/configs/config.toml > > When running `/scripts/start.sh` or manually `./keep-client --config /Users/dp/go/src/github.com/keep-network/keep-core/configs/config.toml` shows the following error: > > ``` > > 2022-08-30T12:06:47.592+0200 FATAL keep-main keep-core/main.go:51 unknown flag: --config...

> You need to use `start` command: > > ``` > ./keep-client start --config /Users/dp/go/src/github.com/keep-network/keep-core/configs/config.toml > ``` ah.. yea, this works. Can you pls update `start.sh` as well?

Tested locally with the deployed contracts. I was able to run a client `./keep-client start --config /Users/dp/go/src/github.com/keep-network/keep-core/configs/config.toml --developer` Also tested a couple of ethereum configs to make sure we can...

Can we split "Flags" into "Flags" and "Global Flags" just as we have in the subcommands? Also, the order is a bit strange here, ex --help is between --goerli and...

> @dimpar The help is autogenerated by the cobra. So not much we can do without modifying the cobra templates. Would you mind creating an issue listing all the improvements...