Michael Diamond

Results 150 comments of Michael Diamond

Related: the newly added `--modtime` flag provides another mechanism for invalidation.

Idea: reimplement scopes _as_ a modtime file in the cache directory. Then scope-wide invalidation would simply involve `touch`-ing that file, avoiding the need for some sort of more bespoke cleanup...

Looked at these and a few other options, and I'm at least not convinced it's worth migrating. It would be interesting to see the diffs if someone feels motivated to...

This works now and will be released as part of 0.6.0.

> it seems like occasionally `file`'s modtime isn't being updated Yeah I'm able to [reproduce this](https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=305c97b62c326b0e0695f9d875aa07ee) pretty consistently in the Rust playground. I guess modtime updates simply aren't atomic. **Edit:**...

@kumy you might have thoughts on this FR too.

I'm pretty surprised to discover that there's no support for a non-binary encoding, nor a clear plan to implement one. The [gRPC-web spec](https://github.com/grpc/grpc/blob/master/doc/PROTOCOL-WEB.md#protocol-differences-vs-grpc-over-http2) specifically calls out JSON as a valid...

> Do you mind sharing what motivates you to look for a non-binary encoding? I was hoping to make debugging in the browser easier by being able to configure requests...

I know this is tangential to the issue, but since we're talking about it I'd like to suggest _not_ using protobuf.js. Since November we have migrated our application off protobuf.js...

Stalebot go away.