Dimitri Fontaine

Results 239 comments of Dimitri Fontaine

Your current PR includes a FASL file it seems, of course I won't include it in the final merge. Also, you mentioned on IRC wanting to add unit testing to...

Hi @phoe ; did you figure out how to run `make check` or `make check-saved` to pass the unit tests locally? They depend only on having a local Postgres instance,...

Ping? anything we should still do about this one?

Seems editing with the GitHub web UI makes it hard to pass our CI indentation test. At the minute I need to refresh my dev environment (Docker and macOS issues,...

I finally managed to fix my Docker Desktop installation ; and then re-install the Citus indent tooling following the documentation at https://github.com/citusdata/citus/blob/main/STYLEGUIDE.md. Thanks for your contributions @Bodobolero !

> * It does not look acceptable to include "schema.h" or "catalog.h" in file `pgsaql.c`. I'll try to find a workaround Usually that involves creating a new C module that...

Thanks for pushing all the work Hanefi, I like what we ended-up with!

I am confused here: 1. In #750 the reporter is using test_decoding, not wal2json. 2. The comment here is mentioning a bug in wal2json: can we link to the wal2json...

PostgreSQL logical decoding does not support DDL. This is documented both in PostgreSQL and in pgcopydb. CREATE and DROP keywords introduce DDL commands.