pgcopydb icon indicating copy to clipboard operation
pgcopydb copied to clipboard

Use our own memory area for editing libpq static error messages

Open Bodobolero opened this issue 11 months ago • 2 comments

see segmentation fault described in https://github.com/neondatabase/neon/pull/10706

Bodobolero avatar Feb 15 '25 12:02 Bodobolero

Seems editing with the GitHub web UI makes it hard to pass our CI indentation test. At the minute I need to refresh my dev environment (Docker and macOS issues, re-install Citus indentation tooling). Will have another try later this week.

dimitri avatar Feb 24 '25 15:02 dimitri

Seems editing with the GitHub web UI makes it hard to pass our CI indentation test. At the minute I need to refresh my dev environment (Docker and macOS issues, re-install Citus indentation tooling). Will have another try later this week.

I couldn't get your Citus indentation tooling to run on my Mac. If you find a solution pls let me know. That is why I couldn't really fix the style problems myself, since your GitHub workflow doesn't output what it doesn't like, either.

Bodobolero avatar Feb 24 '25 16:02 Bodobolero

I finally managed to fix my Docker Desktop installation ; and then re-install the Citus indent tooling following the documentation at https://github.com/citusdata/citus/blob/main/STYLEGUIDE.md. Thanks for your contributions @Bodobolero !

dimitri avatar Apr 01 '25 11:04 dimitri