Dimitre

Yes I can understand that. there is more haha. I don't think player->setPixelFormat(internalPixelFormat); is needed after setPlayer(std::make_shared()); because internally setPlayer calls setPixelFormat which by itself calls player->setPixelFormat

### EDIT, merged - https://github.com/openframeworks/openFrameworks/pull/6829 and this line ``` class ofVideoPlayer : public ofBaseVideoPlayer,public ofBaseVideoDraws{ ``` can be changed to ``` class ofVideoPlayer : public ofBaseVideoDraws{ ``` as it is,...

Room for improvement in ofAVFoundationVideoPlayer: seekToTime calls createAssetReaderWithTimeRange and each call it parses the information about the correct video and audio track, starting in the line ```objective-c NSMutableDictionary * videoOutputSettings...

AVFoundationVideoPlayer seekToTime (that is called by setPosition) creates a new asset reader with the function ```objective-c [self createAssetReaderWithTimeRange:CMTimeRangeMake(time, duration)]; ``` starting with the current time to the end of the...

### Edit: merged - https://github.com/openframeworks/openFrameworks/pull/6821 Hey @ofTheo still talking about the shared_ptr as a function parameter, I still think it is an issue but there is a minimal solution to...

### Edit, A little bit simpler, after this merged PR https://github.com/openframeworks/openFrameworks/pull/6823 ### Another simplification here https://github.com/openframeworks/openFrameworks/pull/6829 **Video Player** ``` ofVideoPlayer < ofBaseVideoPlayer, ofBaseVideoDraws ofBaseVideoPlayer < ofBaseVideo ofBaseVideoDraws < (ofBaseVideo, ofBaseDraws,...

I've recently noticed when using AVFoundationVideoPlayer, if I call close it free "some" memory but not all. but if I rebuild the object using setPlayer it releases a lot more...

This PR was merged https://github.com/openframeworks/openFrameworks/pull/6824 Now replace spaces to tabs, fix identation https://github.com/openframeworks/openFrameworks/pull/6838

This function is called to actually draw the video every frame, lets see what happens in each function here. There are lots of things going on to create a mesh...

@Miles-Tone I've just tried your fix and it seems everything is flipped now. testing on 0.11.2 release curiously for me it worked if I switched the logic to the opposite:...