Dimitri De Jonghe

Results 16 comments of Dimitri De Jonghe

> I think it's time to write a BEP. yes, it's time :)

If so, then please make sure that the error returned is appropriately labeled. This wasnt the case before

more info: KeyError due to returned `{'size': inf}` when `self.threshold > len(subfulfillments)`

not an issue after https://github.com/interledger/rfcs/issues/87

Is this still an issue with #28 merged? cc @r-marques

shouldn't be an issue, see: https://github.com/interledger/five-bells-condition/blob/master/src/types/preimage-sha256.js#L96

Condition is an abstract class and should only be initialized by it's children (practically) I think the example might be misleading... we could change it

will move to bdb extension of cc

I think you can distinguish a bit more precise: - circuit topology: how things are wired up (electronic circuit schematic) - circuit instantiation: the actual values/attributes for each component in...