David Hotham

Remove more code

1

At some point in https://github.com/python-poetry/poetry/pull/6058, it wasn't clear to me whether I should be writing `dependency.accepts(package)` or `package.satisfies(dependency)`. It turns out that there are no callers of `Dependency.accepts()`, so I...

use tempfile.TemporaryDirectory

10

cf https://github.com/python-poetry/poetry/pull/5522 but note that there's a testcase in this repository: https://github.com/python-poetry/poetry-core/blob/8c75c1ae53996be8c4c88ccc2c04dfd6940e0290/tests/utils/test_helpers.py#L90. So if the pipeline passes that should give us confidence that this is good,

Somewhat related to #164. I considered just adding this as a comment there but decided that it was different enough to get its own issue. If you think they're basically...

unsatisfiable schema when flattening an enum and denying unknown fields

1

The following generates an unsatisfiable schema ```rust #[derive(JsonSchema)] #[schemars(deny_unknown_fields)] pub struct MyStruct { pub property: String, #[schemars(flatten)] pub enumeration: MyEnum, } #[derive(JsonSchema)] #[schemars(rename_all = "lowercase")] pub enum MyEnum { Variant(String),...

Validation with #[serde(transparent)]

3

I was excited to see the new validation arriving in 0.8.4, as I was hoping that I could get rid of some hand-written parts in my own code. But I...

Setting a maximum and minimum value for more numeric types, where that's possible. Would be nice to do this for more types, but while we have nothing better than `f64`...

A series of commits tightening up the type-checking in various places

Don't search secondary repositories if not required

15

Not sure whether this is controversial or just obviously sensible... Always searching secondary sources is bad for performance: and generally just isn't what people mostly expect. Here's a behaviour change...

Remove dead code

2

I thought I'd have a go with https://pypi.org/project/vulture/ It reports rather a lot of false positives and I doubt that it's going to be worth the trouble of maintaining an...

disambiguate direct-origin dependencies in show-outdated

1

if you have, say: ```toml [tool.poetry.dependencies] poetry = "^1.2.0b3" [tool.poetry.dev-dependencies] poetry = {git = "https://github.com/python-poetry/poetry.git"} ``` and go `poetry show --outdated` then you hit the runtime error `Unknown direct dependency...