poetry-core use tempfile.TemporaryDirectory

use tempfile.TemporaryDirectory

Open dimbleby opened this issue 2 years ago • 10 comments

cf https://github.com/python-poetry/poetry/pull/5522

but note that there's a testcase in this repository: https://github.com/python-poetry/poetry-core/blob/8c75c1ae53996be8c4c88ccc2c04dfd6940e0290/tests/utils/test_helpers.py#L90. So if the pipeline passes that should give us confidence that this is good,

Apr 30 '22 15:04 dimbleby

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.5% Duplication

Apr 30 '22 15:04 sonarcloud[bot]

Looks like Windows and python3.7 are not happy with this, https://bugs.python.org/issue26660 presumably.

if and when we eventually get to do this, should probably remove the unit test case also - it wouldn't make much sense to have a unit test for tempfile function.

Apr 30 '22 15:04 dimbleby

Re: implementing this now, one option is https://github.com/python-poetry/poetry/pull/5522#issuecomment-1120488761

May 18 '22 02:05 neersighted

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

Aug 22 '22 07:08 sonarcloud[bot]

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.