Dmitrijs Milajevs

Hi, this is impressive analysis! I'll share some context. At the time NLTK's CoreNLP REST bindings (`CoreNLPServer` and friends) were developed, the Stanford team came up with their own CoreNLP...

> And regarding tests - I was looking into automatically downloading some of the third party tools prior to executing the CI tests. In fact, that is how I rediscovered...

If you go with proposed solution, don't use mutable default argument values, change def tree(synset, rel, traversed=set()): To def tree(synset, rel, traversed=None): if traversed is None: traversed = set() Best,...

Looks good. Just some minor comments. It should be ``if properties is None``, not ``if properties == None``. ``assert self.tagtype in ['pos', 'ner']`` should be ``assert self.tagtype in ['pos', 'ner'],...

It's great you are interested in the issue. If you have any questions, ask them here.

Sure! A good first step is to open a pull request.

> before fix : [('my', 'O'), ('phone', 'O'), ('number', 'O'), ('is', 'O'), ('1111\xa01111\xa01111', 'O')] after fix : [('my', 'O'), ('phone', 'O'), ('number', 'O'), ('is', 'O'), ('1111', 'DATE'), ('1111', 'DATE'), ('1111',...

you should be able to manually use CoreNLP Rest API and intercept returned result

The actual call to corenlp should be mock, then tests won't need corenlp running.

not yet, but it should be easy to extend. have a look to - https://github.com/dimazest/google-ngram-downloader/blob/master/google_ngram_downloader/util.py#L101 - https://github.com/dimazest/google-ngram-downloader/blob/master/google_ngram_downloader/util.py#L48 to build records with different fields