Dima Ryazanov
Dima Ryazanov
Found the last working version: 1066514671 (11.30.4). Though when I run it, the same three errors show up in logcat, so I guess none of them are relevant?
Just tried installing it - but no, didn't make a difference.
@sir-sigurd: I removed a lot of the existing hashing code and made everything much simpler, for two reasons: - Hashing parts instead of whole files is better for parallelism, so...
> For something like `quilt3.Package().set_dir('.', 's3://allencell/test').build('test/test', registry='s3://quilt-dev-null')` will it still use the old algorithm? No, it will use the new algorithm for everything (but will need to download the data...
@akarve: not sure I understand what you mean here: > 2. Object in S3 does not have checksum, will not be copied - use old SHA256 hash (requires streaming object)...
Any idea what's going on with docs? I ran `build.py`, but it didn't do anything. Also, it's just blank lines.
> @dimaryaz does this PR supports `quilt3 verify` for packages with old hashes? It does not. It's doable - we'd need to keep the old hashing code for that.
> I am OK dropping support for `quilt3 verify` but in that case we should delete the code so users don't call it. You mean, we don't need it for...
> As long as we have an error message for the "old package" case (we can use manifest version) then the new client can fail `quilt3 verify` on old manifests...
> OK do you agree that old clients (which from the code don't even seem to check `hash.type` (right?)) that verify and install both will just fail with a new...