Dmitrii Kuvaiskii comments

Results 681 comments of


                                            Dmitrii Kuvaiskii

[LibOS] No input validation is done for flag parameter in fchownat syscall

`fchownat()` implementation in Graphene does some checks (but doesn't care about flags, uid, gid) and then doesn't perform any "change ownership" logic but simply returns success: https://github.com/oscarlab/graphene/blob/f1a9c785128522ae4abc604a7ae10f4d4e7f0573/LibOS/shim/src/sys/shim_file.c#L239 Technically, Graphene doesn't...

[CI] LTP: Add MAP_PRIVATE patch to LTP sources and enable LTP in SGX CI

Jenkins, test this please

[CI] LTP: Add MAP_PRIVATE patch to LTP sources and enable LTP in SGX CI

Jenkins, test this please

[CI] LTP: Add MAP_PRIVATE patch to LTP sources and enable LTP in SGX CI

Jenkins, test this please

[CI] LTP: Add MAP_PRIVATE patch to LTP sources and enable LTP in SGX CI

Jenkins, retest this please

[CI] LTP: Add MAP_PRIVATE patch to LTP sources and enable LTP in SGX CI

Jenkins, test this please

fd passing fails -- sendmsg ignores ancillary data

This limitation is still there. I once tried to fix it with this (not merged) PR: https://github.com/oscarlab/graphene/pull/1511. But the problem with sending ancillary data in `sendmsg` (via `SCM_RIGHTS` flag) is...

`ld.so` is at a different path than on Linux

Doesn't seem like much of a problem to me. But ideally (and for other reasons) I would prefer to not use a `/lib` path for Graphene-patched libs but instead something...

Run command as specific user in gsc

Good catch. Indeed, we just assumed the `root` user in GSC Dockerfiles. @vahldiek Do you know of a quick fix for this?

Supporting timerfd_create

Not any time soon, unfortunately. There are plans to work on such low-level interfaces, but this work will not be done earlier than say mid-summer. We are aware that some...