Dmitrii Kuvaiskii

Looks like a simple performance optimization, but someone will need to do thorough performance analysis of this change. Doesn't seem too important at the moment, so assigning low priority.

@boryspoplawski, can you verify that #1000 fixes your test case? Also, can you post your test case?

We just merged #1000 so this issue is fixed. If #1000 doesn't fix all problems with `sendfile`, please reopen this.

`sendfile()` calls `handle_copy()`. This function is really bad and needs to be re-written. We found yet one more issue with `handle_copy()`. It wants to change the offset in the file...

We rewrote `sendfile` implementation but there are quite a few TODOs and corner cases: https://github.com/oscarlab/graphene/pull/2500. So keeping this issue open.

Is it because the normal environment (normal Linux) searches through default paths if `LD_LIBRARY_PATH` is unset, and the Graphene environment doesn't have this fallback?

@llly Could you try it on the latest Graphene? After the `v1.2-rc` release, we had a bunch of bug fixes and small changes to the IPC (Inter-Process Communication) subsystem in...

@llly How can we quickly reproduce it? What is the Python script you tried and is there anything special you did in `python.manifest.template`?

@glorysdj Unfortunately, the manifest you provided requires a very specific environment on the machine (Python3.6, Java, Spark, something called `zinc`, etc). So we won't be able to reproduce this. Anyway,...

This is still the case on current master: https://github.com/oscarlab/graphene/blob/4cb98219d8e302055587a8952c1102415a72ba42/Pal/src/host/Linux/db_devices.c#L43 Even though this particular piece of code was rewritten. This doesn't seem to matter to real-world applications, so assigning very low...