Dmitri Perunov

When using promotion with `Item percentage discount` or `Item fixed discount` actions, then adjustments are applied on `AdjustmentInterface::ORDER_ITEM_PROMOTION_ADJUSTMENT` (or `ORDER_UNIT_PROMOTION_ADJUSTMENT`, didn't check) level. In such case `CartView` ``` "cartDiscounts": []...

[Bug] CartBlamerListener is never called on carts as it listens on incorrect event

3

CartBlamer's purpose is to be called on each request by authenticated customer and in case current request is one of `/carts/{token}` requests, then attach current customer to the cart. This...

[RFC] AssignCustomerToCartHandler is stateful

1

https://github.com/Sylius/ShopApiPlugin/blob/3ace12724f53c330d6b894fe2bbe639ecc140d76/src/Handler/Cart/AssignCustomerToCartHandler.php#L42 `AssignCustomerToCartHandler` uses `ShopUserAwareCustomerProvider`, which uses `loggedInShopUserProvider`. That makes `AssignCustomerToCartHandler` stateful by depending to currently logged in user. I think this is not optimal and should be avoided the same...

Multiple "getChannel"s ignore "enabled" property of Channel

2

I've encountered two cases, but codebase needs to be grepped for more. https://github.com/Sylius/ShopApiPlugin/blob/master/src/ViewRepository/Product/ProductCatalogViewRepository.php#L88 https://github.com/Sylius/ShopApiPlugin/blob/master/src/ViewRepository/Product/ProductLatestViewRepository.php#L61

It appears that `Http/RequestBasedLocaleProvider` is barely used with the endpoints, which means dynamic locale change is not supported by most of the endpoints. For example [Handler/Cart/PickupCartHandler](https://github.com/Sylius/ShopApiPlugin/blob/master/src/Handler/Cart/PickupCartHandler.php#L47) takes default channel locale...

In order to get access to funds more quickly and get seller protection, tracking information should be sent to paypal automatically. https://developer.paypal.com/docs/tracking/ Given order purchased with paypal and has items...

PayPayClient shouldn't be using channelContext under the hood

1

https://github.com/Sylius/PayPalPlugin/blob/c1c5d4586c3e792d0e062f672b830840583018a1/src/Client/PayPalClient.php#L118 `channelContext` makes Client stateful and denies ability to select right `Partner-Attribution-Id`. Additionally `Partner-Attribution-Id` seems optional, but asserted as required at `Provider/PayPalConfigurationProvider->getPartnerAttributionId`  Logic for getting `GatewayConfig` at `Provider/PayPalConfigurationProvider` doesn't...

Currently all admin/shop/override controllers are in the same directory, which makes it harder to understand what goes where. Proposition to use ``` Controller/Admin/EnableSellerAction.php Controller/Admin/DownloadPayoutsReportAction.php Controller/Shop/** Controller/Webhook/** Controller/Order/OrderItemController.php ``` `OrderItemController.php` can...

[Api] `Serializer\ImageSerializer` missing `$data['path']` check

2

**Sylius version affected**: 1.13 **Description** Potential hard to debug place, which can be solved with extra assert. `ImageNormalizer` operates on assumption, that serialized image will have `path` array element, at...

[Refactor][ApiBundle] Unify section resolver usage

1

### 1 Currently `ApiBundle` uses mix of techniques to determine current api section: - Uri based check - Route name based check - Currently logged in user based check Examples...