ShopApiPlugin icon indicating copy to clipboard operation
ShopApiPlugin copied to clipboard

Locale provider Http/RequestBasedLocaleProvider is not used in Handler/Cart/PickupCartHandler

Open diimpp opened this issue 6 years ago • 0 comments
trafficstars

It appears that Http/RequestBasedLocaleProvider is barely used with the endpoints, which means dynamic locale change is not supported by most of the endpoints.

For example Handler/Cart/PickupCartHandler takes default channel locale and subsequent cart related handlers take locale from Order and not from RequestBasedLocaleProvider.

Additionally, RequestLocaleSetter does the same job as Http/RequestBasedLocaleProvider, but in more simplistic way.

In the end, some kind of LocaleContextInterface aware solution should be devised. Maybe FirewallAndRequestBasedLocaleContext or something along this lines.

diimpp avatar Jun 16 '19 15:06 diimpp