Salvatore Di Guida
Salvatore Di Guida
@haberman can you see any issues in this PR? Let me know if you find problems in the proposed changes.
I do not know if I can add a unit test here. Apart from that, are the changes ok? Do you want me to rebase the branch? Thanks
> The changes look fine. I am just concerned that recursive lookup of proto files was broken and we didn't know it. A unit test could help ensure that recursive...
> > The changes look fine. I am just concerned that recursive lookup of proto files was broken and we didn't know it. A unit test could help ensure that...
> > Remove output folder if already exists: this guarantees that you always produce updated generated sources, and avoids the OSError if you forget to delete it. > > How...
Hi @sheneska, thanks for looking into this. It is not clear to me what you are asking me with > try to `apply` this separately. Should I run the `apply`...