digiwand

Results 48 comments of digiwand

@seaona @naugtur This is expected behavior at the moment because we need to reconnect the streams when the Service Worker restarts. This is the issue related here: https://github.com/MetaMask/metamask-extension/issues/14845 I have...

Great call out and suggestion @adonesky1! Looks good to me. The first message was copied from a mock supplied in this [Slack thread](https://consensys.slack.com/archives/GTQAGKY5V/p1659966850991299?thread_ts=1659958204.365809&cid=GTQAGKY5V). I moved one comma and kept the...

Hi @coreyjanssen, No problem! I like this update, and I'm up for updating this. One thing that I would miss from the copy that has been merged > By clicking...

Awesome!!! I think this is an A1 update! Thanks @coreyjanssen! :D Updated here: https://github.com/MetaMask/metamask-extension/pull/15744

[out of scope] confirmed that the provider error is intermittent after seeing it pass here https://github.com/MetaMask/metamask-extension/pull/15494/commits/14db9cc4ff8a656f90bc2b96a08c38fc60d9feff @jpuri @Gudahtt

Hey @jyoti, thanks very much for bringing this up! I didn't know it was causing difficulties to work with. I'll avoid adding `/` in the branch names from here on

@jpuri I agree we should only keep the service worker running for connected dapps, when the pop-up is open, and when the home.html page is open. Let me double-check this...

Hey @jpuri, good catch. I think this fixes it https://github.com/MetaMask/metamask-extension/commit/d259d04d8c5c9226c0b98bb7397fdb485dbdaa08 (merged commit)

@seaona Thank you for the thorough testing! I think there is some crossover testing of https://github.com/MetaMask/metamask-extension/pull/14781 and this PR, which is actually great you tested both. I believe none of...

Sorry, that was a typo slip. I meant the popup* not mobile. @adonesky1