Hitesh Kanwathirtha

Results 19 comments of Hitesh Kanwathirtha

I don't plan to PR this since I don't have time to exhaustively test or better factor this but in case it's useful to anyone else, I have a port...

Apologies for the poor experience @divan- I hadn't kept this module up-to-date with new N-API changes, but there is a [PR](https://github.com/digitalinfinity/generator-napi-module/pull/3) from @andreek that should probably resolve your issues. I'll...

I'll edit the issue to include the links to the issues that are being tracked by this meta-issue

@mhdawson I've added a few issues here- feel free to update the issue to add any I might have missed (and I'll add more to this list as they come...

Thanks @YafimK - can you create a separate issue in nodejs/node with more details on what change you'd like to see, perhaps with the use case- I can then update...

For node-native-histogram, I've determined that the benchmark is not doing a significant amount of work, so its effectively just measuring the difference between napi_call_function and nan's function call API. Given...

@boingoing can you help point @bmeck to the right APIs here? I *think* it's this API but I don't think we've documented them yet: https://github.com/Microsoft/ChakraCore/blob/master/lib/Jsrt/ChakraCore.h#L141 cc @liminzhu

@joaocgreis any thoughts on whether we can have GitHub CI setup for the node-chakracore repo? While we could manually trigger CI, curious if there's any reason why we can't have...

Hmm, @kfarnung shouldn't https://github.com/nodejs/node-chakracore/pull/285 have fixed the issue around child processes that seems to be affecting @jackTheRipper when he's using mocha?

Hi @jackTheRipper - did you get a chance to try this without JSDom?