Diego Muracciole comments

Results 180 comments of


                                            Diego Muracciole

Generate the document's ID on demand instead of the class constructor

I was trying to unify our pdfkit fork with the real package, and this introduces a new change. Can we do this on react-pdf side by overriding the trailer?

3.4.4 font changes no longer apply

Should be fixed in latest version. Please re-open if it's not the case

fix: Allow src and href attributes to also be numbers

You linked a pdfkit line, but that does not mean `@react-pdf/renderer` allows passing numbers as src or href. In which case we would want this?

Compile error - module not found - cannot resolve 'react/jsx-runtime'

Unrelated to this lib

When I try to run my code It shown an error in yoga-layout and "@react-pdf/renderer"

You had `"yoga-layout": "^3.0.2"` installed for some reason. We aren't shipping this until next version of react-pdf. It should no longer be a problem there

Render charts in a downloadble PDF

[EvHaus/react-pdf-charts](https://github.com/EvHaus/react-pdf-charts) looks promising. Charts are outside this lib scope

Upgrading from @react-pdf/renderer 4.1.2 to 4.1.3 causes a variety of issues with `lineHeight` styles

This is likely caused by https://github.com/diegomura/react-pdf/pull/2952. but it's unclear yet if it's a bug (despite the `render` prop example). Before it line height was incorrectly computed. Can you guys show...

fontWeight only using first definition

Hey. Couldn't replicate. This is my code and the produced doc below: ```js const styles = StyleSheet.create({ body: { paddingTop: 35, paddingBottom: 45, paddingHorizontal: 35, position: "relative", }, regular: {...

fontWeight only using first definition

This should be fixed in latest version. Please re-open if it's not the case

Hide the grey area of the PDF previewer?

PdfViewer just leverages browser PR viewer as it just renders an iframe. Any customization or special viewer beyond that is up to the app