Diego Marquez

chore: bake protoc into the hermetic build docker image

2

WIP - this will be ready for review once https://github.com/googleapis/sdk-platform-java/pull/2615 is merged

Non-primitive values should not be put into path parameters

6

Similar to #1016 _In some cases, the generated client library would put complex object to ~query~ path parameters, like [here](https://github.com/googleapis/gapic-generator-java/blob/889f316d7dfcfdaf826cb8024166cc8eabeaef0d/src/test/java/com/google/api/generator/gapic/composer/rest/goldens/HttpJsonComplianceStub.golden#L176) , the proto definition for this method is [here](https://github.com/googleapis/gapic-generator-java/blob/889f316d7dfcfdaf826cb8024166cc8eabeaef0d/src/test/proto/compliance.proto#L64). The...

feat: gapic-generator-java to perform a no-op when no services are detected

10

Fixes https://github.com/googleapis/sdk-platform-java/issues/2050 Adds behavior to gracefully perform a NOOP if no services are contained in the generation request. ## Confimation in hermetic build scripts From `generate_library.sh` against `google/cloud/alloydb/connectors/v1` ``` +...

chore: gapic-generator-java noop follow up on hermetic build scripts

2

This is a follow up from https://github.com/googleapis/sdk-platform-java/pull/2460. The checks should pass once it is merged in main and this PR is rebased/updated with the new changes. Since GGJ will NOOP...

Can the GraalVM Presubmit checks be faster?

1

These checks take usually ~35 minutes. I wonder if we can make them faster somehow.  

`error_prone_annotations` dependency is inconsistent in this repo

2

We have `errorprone.version` defined in https://github.com/googleapis/sdk-platform-java/blob/f5f201e9846c46f6e7241a15674d28711fe984f4/java-shared-dependencies/third-party-dependencies/pom.xml#L33 We have `error_prone_annotations` with a different version in https://github.com/googleapis/sdk-platform-java/blob/f5f201e9846c46f6e7241a15674d28711fe984f4/api-common-java/pom.xml#L66

[hermetic-build] java-bigtable generated `proto-*/src/main/proto/**/*.proto`s are different from existing ones

1

## Problem **There are some proto files that are differing, for example `bigtable/admin/v2` :** ## Current (wrong) generation output See https://github.com/googleapis/java-bigtable/pull/2159 for a demo PR ## Details Check googleapis -...

Should we include test resources in `gapic-generator-java:test-jar`?

2

Context in https://github.com/GoogleCloudPlatform/spring-cloud-gcp/pull/2570#issuecomment-1944253401 The spring-cloud-gcp autoconfig generator [tests](https://github.com/GoogleCloudPlatform/spring-cloud-gcp/blob/8ae8db3a386b096d53f71a067c86a94fc7d6e327/spring-cloud-generator/src/test/java/com/google/cloud/generator/spring/SpringWriterTest.java#L34-L36) rely on `TestProtoLoader.parseShowcaseEcho()`, which has a conflicting line that tries to parse the `echo_v1beta1.yaml` from `src/test/resources`, which is not available in the...

From https://github.com/googleapis/google-cloud-java/actions/runs/8149990119/attempts/1 ``` /usr/local/lib/python3.11/site-packages/library_generation/postprocess_library.sh: line 89: REPO_BINDING_VOLUMES: unbound variable [431](https://github.com/googleapis/google-cloud-java/actions/runs/8149990119/job/22275511886#step:4:432)Library postprocessing failed [432](https://github.com/googleapis/google-cloud-java/actions/runs/8149990119/job/22275511886#step:4:433)Error: Process completed with exit code 1. ``` The `unbound variable` error comes from `set -u` that will...

gax: cannot compile with references to SNAPSHOT of `api-common`

4

Local development of gax may fail if we are working with a SNAPSHOT of `api-common` (i.e. `bazel build //gax:...`. Maven installs work properly This is because of [dependencies.properties](https://github.com/googleapis/sdk-platform-java/blob/336e8f36a90a55a50d2da0a7f5ad3d9bb3a87187/gax-java/dependencies.properties#L72) of gax...