diego-ramos

Results 11 comments of diego-ramos

Demo version is still on 3.3.9 version I'm working on 3.4. I have been testing this issue on 3.4 version local and online demo and line by line the totals...

Hi @jekkos yes this is the same error I got ( The URI you submitted has disallowed characters) before the fix, and the base64_encode($payment_id) was part of the fix. Maybe...

Sure I'll take care of that, bur it could take some time. Before my fix I tried encoding the URL and it doesn't work, again, maybe we need to talk...

@jekkos As far I have been testing and working with the lastest master version, the one that inlcudes your unit test for my helper ), I have not seen any...

> @diego-ramos is it sonething you could adapt? Here is a new version, tested on MariaDb, and it worked, I cannot test it on older version on Mysql right now,...

> @diego-ramos sorry I wasn't more clear. You did way too much work here. Just call the dropForeignKeyConstraint() function in the migration helper. This is what that function is for....

> Curly braces formatting needs to be fixed for PSR-12 compliance. Take a look at the rest of the code base to see the formatting for if statements. Done!

@objecttothis @BudsieBuds , Hi any news on this review?

@jekkos Because as I told you before urlencode function is not working on that point, is something with codeigneter. You can try to see it, the result is the same...