SecurityJedi

Results 17 comments of SecurityJedi
trafficstars

@BethanyZhou per your comments https://github.com/Azure/azure-powershell/pull/18790#issuecomment-1188735810 I have updated the cmdlets and created a new PR

@BethanyZhou Updated code see comments below: -Parameter Teams of cmdlet New/Update-AzSentinelDataConnector does not follow the enforced naming convention of using a singular noun for a parameter name.","Consider using a singular...

@VeryEarly i have fixed the items from comment here and per email , both are in the lastest commit.

@WaterByWind fair, but it doesnt have the ability to dynamically update a list from a provider like this.

On it will, update and commit.

@v-spadarthi Fixed. was missing a couple managed identity settings: ![image](https://user-images.githubusercontent.com/25964057/181343165-7496dc54-8f26-471e-91d9-ff68a09f2948.png)

@v-spadarthi -fixed validations (changed Playbook Name to PlaybookName is all deployment files) -fixed mainTemplate deployment issue (repackaged to zip too)

@v-spadarthi Do you need anything else from me to review this for merging? its been hanging for some time.

Hi @ErnieBot We are aware of this issue. The API version used by the PowerShell client does not always return tactics. Updated APIs are coming and we will be updating...

Hi @opticon454 We have a new version in review. the PR is here https://github.com/Azure/azure-powershell/pull/17286