Isaiah Muli

Results 10 comments of Isaiah Muli

> @dicksonmulli can we also have a method that clients like this can use? https://github.com/openmrs/openmrs-module-legacyui/blob/1.16.0/omod/src/main/java/org/openmrs/web/dwr/DWRConceptService.java#L471-L475 What kind of a method? Kindly explain

> A method like `public String getErrorMessageIfInValidNumericValue(Float value, Integer conceptId, Integer patientId)` would be even more useful because it returns the exact error message which includes the expected range. For...

> How do we deal with cases where a concept numeric already has absolute high and low values set, but also has reference ranges? Do we ignore the former? Do...

> No. What i mean is that in addition to the concept reference ranges, the concept numeric itself may have values already set as you can see here: https://demo.openmrs.org/openmrs/dictionary/concept.htm?conceptId=5089 Right....

> So what happens when one has both set? I have tested a scenario when both are set and it's working as expected. Concept Numeric values are evaluated first then...

@dkayiwa is there anything else pending for this PR?

> @dicksonmulli if there are no reference ranges defined, but the concept numeric record has values, do we end up using these values to create an obs reference range? At...

> Work on the documentation as i continue reviewing. Kindly share a link page where we can add this documentation.

> This may be an issue for some of the use-cases here. Specifically, reference ranges for results on children can be substantially different from the ranges for adults, and I'm...

>@dicksonmulli I'm thinking about the scenario where we already have a reference range defined on the ConceptNumeric, but then also have a series of the new ConceptReferenceRange classes defined for...