khmer icon indicating copy to clipboard operation
khmer copied to clipboard

[MRG] test, and actually fix, find-nullomers script; add documentation and test input file

Open ctb opened this issue 8 years ago • 3 comments

Fixes #1754.

  • [x] Is it mergeable?
  • [x] make test Did it pass the tests?
  • [x] make clean diff-cover If it introduces new functionality in scripts/ is it tested?
  • [x] make format diff_pylint_report cppcheck doc pydocstyle Is it well formatted?
  • [x] Did it change the command-line interface? Only backwards-compatible additions are allowed without a major version increment. Changing file formats also requires a major version number increment.
  • [x] For substantial changes or changes to the command-line interface, is it documented in CHANGELOG.md? See keepachangelog for more details.
  • [x] Was a spellchecker run on the source code and documentation after changes were made?
  • [x] Do the changes respect streaming IO? (Are they tested for streaming IO?)

ctb avatar Sep 01 '17 00:09 ctb

Ready for review & merge.

ctb avatar Sep 01 '17 00:09 ctb

I super strongly suspect I can get away with a smaller SIZE - SIZE/2, to be specific. Hmm.

ctb avatar Sep 01 '17 00:09 ctb

Codecov Report

Merging #1768 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1768   +/-   ##
======================================
  Coverage    0.05%   0.05%           
======================================
  Files          80      80           
  Lines        9835    9835           
  Branches     2485    2485           
======================================
  Hits            5       5           
  Misses       9830    9830

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bb29c77...99ae031. Read the comment docs.

codecov-io avatar Sep 01 '17 01:09 codecov-io