khmer
khmer copied to clipboard
[MRG] test, and actually fix, find-nullomers script; add documentation and test input file
Fixes #1754.
- [x] Is it mergeable?
- [x]
make testDid it pass the tests? - [x]
make clean diff-coverIf it introduces new functionality inscripts/is it tested? - [x]
make format diff_pylint_report cppcheck doc pydocstyleIs it well formatted? - [x] Did it change the command-line interface? Only backwards-compatible additions are allowed without a major version increment. Changing file formats also requires a major version number increment.
- [x] For substantial changes or changes to the command-line interface, is it
documented in
CHANGELOG.md? See keepachangelog for more details. - [x] Was a spellchecker run on the source code and documentation after changes were made?
- [x] Do the changes respect streaming IO? (Are they tested for streaming IO?)
Ready for review & merge.
I super strongly suspect I can get away with a smaller SIZE - SIZE/2, to be specific. Hmm.
Codecov Report
Merging #1768 into master will not change coverage. The diff coverage is
n/a.
@@ Coverage Diff @@
## master #1768 +/- ##
======================================
Coverage 0.05% 0.05%
======================================
Files 80 80
Lines 9835 9835
Branches 2485 2485
======================================
Hits 5 5
Misses 9830 9830
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update bb29c77...99ae031. Read the comment docs.