elvers icon indicating copy to clipboard operation
elvers copied to clipboard

'basename' may not be properly quoted

Open ctb opened this issue 6 years ago • 2 comments

a student used a space in 'basename' in the config yaml file, and it looks like that will break shell commands that aren't properly quoted. I think single quotes should work.

we can add in some tests that do this for basenames containing $ and :)

ctb avatar Jan 30 '19 13:01 ctb

Even if properly quoted, wouldn't this break all commands with assemblies (assembly names become {basename}_ext.fasta)?

bluegenes avatar Jan 30 '19 16:01 bluegenes

On Wed, Jan 30, 2019 at 08:14:12AM -0800, Tessa Pierce wrote:

Even if properly quoted, wouldn't this break all commands with assemblies (assembly names become {basename}_ext.fasta)?

I don't think so - any valid UNIX filename should work, no?

although I can imagine many actual programs barfing :)

an alternative is to put in requirements for basename (only alphanumeric, _, -, and .?)

best, --titus

C. Titus Brown, [email protected]

ctb avatar Jan 30 '19 21:01 ctb