Diarmid Mackenzie

Results 105 comments of Diarmid Mackenzie

What I did as a workaround was: Install patch-package: ``` npm i patch-package ``` Edit `package.json` as per set-up instructions [here](https://www.npmjs.com/package/patch-package) ``` "scripts": { "postinstall": "patch-package" } ``` Modify this...

[Here's](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise/catch) the documentation I can find on `catch()` > The Promise returned by catch() is rejected if onRejected throws an error or returns a Promise which is itself rejected; otherwise,...

If you are using multiple cursors on a single scene, you will hit other problems as well (as I did, and tried to fix in this PR, that's not been...

Yes, sorry, my comment isn't in fact relevant here, although reasons why are a little subtle... `setAttribute()` doesn't work as you might expect in this case. The values aren't copied...

I was a little curious why this happens. It looks like the root cause is [this code](https://github.com/aframevr/aframe/blob/2c4509aa1a9a3c447c08be9facfea0c7d6a9e156/src/core/component.js#L800-L803) ``` function isObjectOrArray (value) { return value && (value.constructor === Object || value.constructor...

I came across this issue again in a project I was working on, and built a component that addresses it. https://diarmidmackenzie.github.io/aframe-examples/component-usage/raycaster-thresholds.html ``` ``` I think it might be worth incorporating...

Looking at the structure of the v3 controller object, I'm guessing that the _max and _min Object3Ds are intended to provide guidelines for the transforms for the trigger, grip etc...

I don't know about the source of these, but pretty sure the best path forwards it to update A-Frame to fit the new model format rather than trying to engineer...

A threejs geometry can have multiple materials, but the A-Frame material component doesn't support this. I suspect that's the issue you are hitting. Whenever I've wanted to do multiple materials...

Great work BTW. Looks like my initial analysis that this was fairly straightforward may have been some way off the mark!