Dennis Huebner

Results 103 comments of Dennis Huebner
trafficstars

I personally don't like how extending the default API works at the moment. There is no way to use the additional API inside a custom service implementation except of casting...

> but it's also type-safe, which is great. I don't propose to change `nameProvider` field to Object. I'm rather looking for a more extensible alternative on how our default implementations...

Maybe something like this? Default service implementation: ```ts export class DefaultScopeComputation implements ScopeComputation { protected readonly services: ST; constructor(services: ST) { this.services = services; } protected nameProvider(): NameProvider { return...

It would also make sense to add an easy to use API for Code Action tests if any

I don't know how useful are other flags, but those seen to be useful: s | Allows . to match newline characters. -- | -- i | Case-insensitive search. Will...

What about a new keyword for multiline matching?

@msujew I meant the `s` flag for: Allows . to match newline characters.

Keyword is not a good idea, because this flag regex specific

Even better results gives `madge --circular lib/grammar/generated/parser.js`

Feel free to merge after accepted! Should we add a label: **accept2ship** ? :)