Daniel Hritzkiv

Results 48 comments of Daniel Hritzkiv

This PR closes #60 Any chance for this to be reviewed and published to npm?

@JaffParker I think there’s an issue with your User entity: ```ts @Column({ name: 'roleId', }) @ManyToOne(type => UserRole) @JoinTable() role: UserRole roleId: number ``` should be ```ts @Column({ name: 'roleId',...

Hey @RickButler. Thanks for this comprehensive PR. I think this looks super promising and useful, especially after a little cleanup. However, seeing as this is a large and fundamental change,...

No, I think we're the only two active-ish maintainers, unfortunately. I've added us as reviewers for the PR

How much code is required to extend ampersand-input-view to support the step attribute? I would argue that this might not belong in the core module, but instead could be achieved...

The tests indicate that isn't not a insidious bug in as much as the tests specifically expect the callback to be called for each event name. (https://github.com/AmpersandJS/ampersand-events/blob/master/test/index.js#L528) The reason for...

What _really_ confuses me is the expected behaviour after reading through the code logic of ampersand-event's `once`: ``` js once: function (name, callback, context) { var self = this; var...

@naugtur tests have been broken across all Ampersand modules for about a year now :( I don't have the expertise or access to fix the CI tests.

Hi. Do you have a link to an example page with Ampersand.js in use?