bull
bull copied to clipboard
chore(deps): bump ioredis from 4.x to 5.x
Closes #2353
This upgrades ioredis from v4 to v5. Per the migration guide, the breaking changes are:
- dropping node v10 (long past LTS window)
- dropping support for custom Promises libraries (like Bluebird)
- any username included in a Redis URL connection string is now always used (v4 required
allowUsernameInURI
to be passed in)
Due to node support being a breaking change, this likely means bull would need a major version bump to v5.
All that said, all tests pass, and no changes were required to bull.
The alternative solution, which is non-breaking would be to allow installation of both ioredis v4 and v5:
"ioredis": "^4.28.5 || ^5.0.0"
I believe in codebases where other dependencies require ioredis v5, v5 will be used; otherwise v4 will be used.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Bump
@manast
when is this planned to be merged?
This is a problem on our end, would love to see this merged
Sorry for the tremendously late response here. The PR looks fine, merging now.
:tada: This PR is included in version 4.10.2 :tada:
The release is available on:
Your semantic-release bot :package::rocket: