David Herges

Results 28 comments of David Herges

This seems also be related to the order of proxy configs: BREAKS with `Cannot read property 'on' of null at catchUpgradeRequest lib\index.js:63:19`: ```json { "/notification/channel": { "target": "wss://foobar.local/notification/channel", "secure": false,...

Hi @chimurai, sure, we have a repro in the office at my employer, w/ `wss://` server. Will check that tomorrow morning. It also affects Angular CLI `ng` users, since they...

Hi @chimurai, if moving the call to `catchUpgradeRequest(..)` to inner `if(shouldProxy(...))`, it does not handle websocket upgrade at all. Changing the code was no solution to us. Changing the order...

Hi, we're using thru @angular/cli 1.0.2 default set up ... what they pull in. Would need to look at exact version next week in office. Cheers, David > On 12....

> (they are called on all invocations of the Sling POST Servlet) yeah, we used it by writing a simple `accepts(SlingHttpServletRequest)` that checks whether the PostProcessor should/must be triggered ......

Hi @bcherny, thanks for the response and your time! Here are the full repros. ### Example A ```json { "title": "Example Schema", "definitions": { "person": { "type": "object", "properties": {...

I found two working version by setting `$ref: '.'` and `$ref: '#'` in the `properties.children.items`: ```json { "type": "object", "properties": { "firstName": { "type": "string" }, "children": { "type": "array",...

I mean, guys, the news is that it's [all regex](https://github.com/ludohenin/gulp-inline-ng2-template/blob/master/parser.js#L38-L58) ... if someone has an idea how, feel free! The code in question, that breaks the builds, is for example:...

A more robust solution is to parse the TypeScript AST (instead of regex) to extract `templateUrl` and `stylesUrls` properties, similar to https://github.com/dherges/ng-packagr/blob/7135c42/src/lib/util/ts-transformers.ts#L4-L31 See also TheLarkInn/angular2-template-loader#54 ans TheLarkInn/angular2-template-loader#70