David Hensle

Results 17 comments of David Hensle

All of the changes present in this pull request are also implemented in the school escorting pull request. The school escorting pull request also includes additional changes to this part...

See [visualization product document](https://docs.google.com/document/d/18MCr2m48b6n_bMaxKeicBQ7HQ_3AZ_4QkhAG6fqBavc) for details

This pull request accompanies the [pull request in the ActivitySim/activitysim_resources](https://github.com/ActivitySim/activitysim_resources/pull/27) containing the full model data. - [ ] The links to data in the example_manifest.yaml in this pull request need...

This issue does not apply directly to the option that uses probabilities to determine the fuel type because that option does not use the vehicle type data. The number of...

Investigating this issue in the re-estimated SEMCOG configs (currently in the SEMCOG example pull request #603) shows that there are just a couple scheduling segments with non-zero squared coefficients. These...

The affected SEMCOG tour scheduling models have been re-estimated after removing the squared terms discussed above. The changes can be seen in [this commit](https://github.com/ActivitySim/activitysim/pull/603/commits/2d21aa72394948897d0d3681f7c73e8338bf610c) and are incorporated in the [updated...

Some context here about why this issue cropped up: As part of the shadow pricing work (#613), there is a step where a data buffer is created to store the...

Thanks for your comments Joe. And please continue to be "nitpicky" as that is what we need in these reviews! I have removed the deuplicative read_spec_file() and left the read_alts_file()...

@JoeJimFlood Thank you for your great comments. I have responded to each in **bold** below. Can you please review the changes and ensure they are satisfactory? Thanks! It might be...