activitysim icon indicating copy to clipboard operation
activitysim copied to clipboard

Published 20 hours ago • verified publisher icon ActivitySim

Flexible Number of Tour & Trip IDs

Open dhensle opened this issue 2 years ago • 2 comments

This pull request removes the hard coded max number of trips and tours available in ActivitySim. For details, see the presentation here and scope here.

dhensle avatar Aug 11 '22 06:08 dhensle

Coverage Status

Coverage remained the same at 0.0% when pulling 69008a9e7f1849f1d679d5f082a38861804b08f4 on dhensle:flexible_ids into 3b7e55198c09fba8b7a125e85fd085d57426607b on ActivitySim:develop.

coveralls avatar Aug 14 '22 20:08 coveralls

All of the changes present in this pull request are also implemented in the school escorting pull request. The school escorting pull request also includes additional changes to this part of the code to add "tour flavors" for school escorting.

dhensle avatar Aug 19 '22 23:08 dhensle

Thanks for your comments Joe. And please continue to be "nitpicky" as that is what we need in these reviews! I have removed the deuplicative read_spec_file() and left the read_alts_file() in place. The comment has been updated.

dhensle avatar Oct 28 '22 16:10 dhensle