Daryl Haresign
Daryl Haresign
OK I rebased and fixed some lint issues. There was an outstanding question about what to do regarding the creation and attaching of the cpp heap. Currently it's being done...
Looks like all CI passed apart from another lint issue. Will push a fix for that now.
> > I'm guessing these will want to be cherry-picked / applied outside of this PR? I have them here so the CI can run successfully. > > Have you...
I pushed a new commit for "[deps: V8 Fix Invalid static_assert](https://github.com/nodejs/node/pull/45704/commits/6987a55a616951ad5efd8e7e8d0089b7894ff46c)" which should address the concern they have with the original patch I suggested. Hopefully we can then get it...
OK, I submitted a CL for the invalid `static_cast` issue and it just landed: https://github.com/v8/v8/commit/eea8a2f22bcf2bcfd12a093a0e1ba762b8d0a5ec I can create a new PR to backport these two fixes now they've both landed...
This PR is rebased on top of #47065 to cherry pick the required fixes in v8. Once that PR lands I can rebase this PR on top of the merge,...
Rebased on top of `main` which now includes v8 11.3. That covers the commits we needed to land in v8 for this.
> Is this ready for re-review? Or is it still blocked on anything? No blockers remain! Thanks
We are making use of `cppgc` in node add-ons. As a result we have modified `tools/install.py` to include all the `cppgc` related headers. We are initializing `cppgc` in our add-on,...