Daryl Haresign

Results 19 comments of Daryl Haresign

In Electron, the cppgc heap will be initialized by Chromium. I don't think anything in this PR clashes with what Electron will want. When they initialize node, they can use...

Erp, I hit the close button by mistake. Please re-approve running the workflows >_

The previous test runs seemed to fail, and actually running my local build of node likewise fails. It seems to be due to a bug in v8: https://github.com/v8/v8/blob/main/src/heap/cppgc/heap-base.cc#L104 I believe...

> The previous test runs seemed to fail, and actually running my local build of node likewise fails. It seems to be due to a bug in v8: > >...

> > The previous test runs seemed to fail, and actually running my local build of node likewise fails. It seems to be due to a bug in v8: >...

Node is still segfaulting when I run it locally: ``` * thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x0) frame #0: 0x0000000100a5c14c node`cppgc::internal::MarkerBase::EnterAtomicPause(cppgc::EmbedderStackState) [inlined] cppgc::internal::SingleThreadedHandle::Cancel(this=) at task-handle.h:27:20...

Looks like there's no `isolate_` set in the `CppgcPlatformAdapter`, which implies `CppHeap::AttachIsolate` has not been called, though it has. After digging a bit, it's because `CppHeap::AttachIsolate` does `static_cast(platform())`, where `platform()`...

Submitted the following v8 bugs: * https://bugs.chromium.org/p/v8/issues/detail?id=13589 * https://bugs.chromium.org/p/v8/issues/detail?id=13590

I added a commit to add `SetIsolate` as a virtual method on the `cppgc::Platform` protocol. Not sure if that's the direction v8 will go to fix the issue, but it...

Please re-approve running the workflows 😅