dgw

Results 632 comments of dgw

Since `get_nick_id()` is the problematic code path, I'm sure we could cut the frequency of this issue down to (almost?) nothing using a `Lock` object and a well-placed `with nick_id_lock:`...

There's no "assume" in plugin-land, only checking registered callbacks. ☺

Realized today that this would also be useful for [w.wiki](https://w.wiki/) links. Meanwhile I've discovered that it isn't too terribly difficult to reuse long-URL handling for short URLs, at least in...

Two things from thinking ahead a little about this today: 1. We should be sure that a refreshed implementation doesn't suffer from the problem described in #2281 2. A revised...

To make the workaround explicit: Avoiding this is as simple as doing e.g. `from sopel.modules import pluginname` and then using `pluginname.the_callable()`, instead of directly doing `from sopel.modules.pluginname import the_callable`.

It's like what I said earlier on IRC about "or a submodule"—but with more nuance, I guess? Plugins that import different commands from submodules of themselves to build the "real"...

This already works as described if `url` is set to auto-title links. Do you have `url.enable_auto_title = False` or similar in your config? (Of course, I realize that if auto-title...

@RustyBower Even if this just means updating `last_seen_url` when `enable_auto_title == False` here so it can be used later if/when someone calls `.title` with no arg? https://github.com/sopel-irc/sopel/blob/13ea685cddf489328ed51d50ce282ec5a8445037/sopel/modules/url.py#L291-L293 (May also require...

Quick note: Reconfirmed with commit 6af4f23d2ea011aa1e5fc9ce5449b2f2bce1bd1c under Python 3.10 on Termux.

Optimistically slotting in for 8.1, assuming @Exirel will rework this branch to follow the plan in #2460. 🙂