dgw

Results 632 comments of dgw

More things to audit after converting to `SetAttribute`: - `if not bad_mask: continue` (https://github.com/sopel-irc/sopel/pull/2687#discussion_r2187907946) - Unnecessary local `bad_masks` in `_hostmask_blocked()` helper (https://github.com/sopel-irc/sopel/pull/2687#discussion_r2187906121) - Allow each field of `_is_pretrigger_blocked()`'s returned tuple...

I propose that the literal `%%` be used to represent a single `%` in the output. If I'm reading the module code right, it shouldn't be too difficult to add...

1) ZNC has supported overriding the VERSION string (or any other CTCP response) for ages. In your own words, "nobody died" from that either. 2) Some IRC networks _require_ that...

Anyone who wants to implement this: The `OnNickMessage` hook is what you'll want to use. (@keigel2001, maybe you'd like to give it a shot?)

> Python 3.8 needs to die. I mean, PyPA had the choice to **not** deprecate the old style so quickly after PEP 639 got implemented. But yes, this is probably...

My point is only that having "people move away from […] older tooling" doesn't _necessitate_ quickly deprecating and removing the older behaviors. It was a choice they made to have...

Honestly, I don't think we even need a deprecation period unless you want to be _really, really_ nice to hypothetical plugin devs doing Crimes™. As stated in the OP, this...

Wouldn't it be simpler to use [``](https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/dialog) with `showModal()`? You get a `::backdrop` for free and don't have to set it up separately.

> Maybe then we could easily expand on this modal window to deal with edits too ? I like that idea. Not to scope-creep this PR, of course, but in...

Been a while. Are you still interested in this, @SnoopJ? I could take it up for Hacktoberfest this weekend, if not.