Charles Comstock
Charles Comstock
I believe I've already accounted for this both in the [comment above](https://github.com/clojure-emacs/clj-refactor.el/issues/528#issuecomment-1188244113) & in [test cases](https://github.com/clojure-emacs/clj-refactor.el/pull/525/files#diff-f78a6cdcd522a7fae3dbadcc142377d69570a8088e0fcb28c4f6d51ae0f7b8fcR173-R225) included in the PR. I will attempt to summarize again though; If a codebase...
I have no trouble with that collaboration model. I also understand that it can be frustrating for you to have a change dropped in your lap without sufficient context. I...
Any updates on splitting this into smaller issues?
I'm curious why the defcustom should still be an alist prefixed by the namespace refer. If the intention is to send the entire defcustom to the middleware, can't we parse...
I think on further reflection, the major concern I have about this, despite it being backwards compatible is that it feels like a very unintuitive syntax to encounter in Emacs...
I can switch the cl-destructuring-bind to `pcase-let` or something if that helps, with regards to the cl-loop though, it's a little trickier as there doesn't seem to be a nice...
Thanks, and thank you for you time spent reviewing as well. After some further thought it's not quite so tricky as I thought with seq-mapcat, though I still maintain the...
Should I add a note to the readme for this? It's user facing, but the cljr-slash feature doesn't appear to be documented there.
Happy to document it in the wiki once this is merged, I guess I was mostly curious if there was any other documentation I should update or add in this...
Added documentation in the wiki: https://github.com/clojure-emacs/clj-refactor.el/wiki/Home/_compare/f70058bac1388cb7094ed56d6b63f1b8dc18f021...ad3bc7a5d570053501464a320122f596f999dd57