Charles Comstock

Unfortunately the pattern used in the tests that are failing is the same one I need to write tests to verify the new behavior. So, while the build may not...

I believe I've addressed all outstanding concerns, updated external documentation and added a changelog entry as well as manually retesting it in a project. I would much prefer we merge...

Just checking back in to see what else needs to be done here before it's merged.

I think we can proceed with the remainder of clojure-emacs/refactor-nrepl#384 as planned. However, until #533 is implemented, we won't know the correct current language context at point. My expectation remains...

Thank you for carefully going through all this and writing it up. I think overall the API spec makes a lot of sense in terms of inputs and the shape...

Thanks for the careful response, I look forward to further details on point 4 when you get the time. I wanted to leave one more comment about point 2 though,...

Thanks, that makes sense to me. I'll take a look at re-implementing the completing-read prompt using this API later this week.

A few specific cases to consider: `set/` should add `[clojure.set :as set]` regardless of language context if it's the only mapping of that alias to a namespace. It should only...

I was aware of `cljr-suggest-namespace-aliases`, but I don't think it particularly impacts any of the changes above though. As far as I understood, it's only present in the client to...

I'm not sure about `cljr-add-missing-libspec` though. At the moment that is a completely orthogonal feature, but I strongly suspect that there is overlap between `cljr-slash` and `cljr-add-missing-libspec` that we could...