David Bariod comments

Results 25 comments of


                                            David Bariod

Handle cheat sheets existing in several upstream repositories

Hey @chubin, sorry for the super super late answer. The feature totally answers my needs. 👍

Gimme known argument empty output

indeed this line is the root cause of the error when there are no accessible go binary from the path https://github.com/travis-ci/gimme/blob/8a1149c5e817fc92a522454149b1821eff770cbd/gimme#L523

Do not assume no color on windows.

@jtnord there have been back and forth pull request on this topic. IIRMC, the last pull request desactived coloring on windows, because color support in the terminal depending on the...

Do not assume no color on windows.

@jtnord what about this one #864 ? @ceriath do you mind to have a look here ?

[logrus] fixes #732 - 20 level options between each standard log level

Indeed, that would be useful to add intermediary log level and keeping backward compatibility. But this first step can not be done without breaking such compatibility. Tagging 2.0.

`entry.Log(logrus.FatalLevel, "fatal level")` doesn't call `logger.Exit(1)`

This is not a bug. It works as documented: ``` ~/src/logrus$ go doc . Entry.Log package logrus // import "github.com/sirupsen/logrus" func (entry *Entry) Log(level Level, args ...interface{}) Log will log...

Improving syslog hook

hello @aluvare thanks for your contribution. I've done some comments/questions on your code changes. We also need passing tests.

Add optional formatter to writer hook

Thanks for your contribution. It is interesting indeed. Can you improve the documentation a bit on the hook.Writer class on how to use the new field and what is the...

Add optional formatter to writer hook

Thanks for your contribution @sivachandran

fix for "fatal error: concurrent map iteration and map write"

@quenbyako the code has changed a lot since this MR. The latest v1.8.1 should contain fixes for this kind of issue. Do you have a reproducible test case which exhibits...