Damian Gryski

Results 286 comments of Damian Gryski

I think `crypto/cipher` has some issues with dispatching to the specialized `xorBytes` implementations, or at least it did once upon a time.

I'll try to take a look into this.

After some patching to get the tests building under tinygo: ``` ~/go/src/github.com/vspaz/rsa-encrypt-decrypt-golang/pkg/cryptolib $ tinygo test -target=wasi panic: unimplemented: (reflect.Value).Addr() Error: failed to run main module `/var/folders/5b/_hr1d1fd3qn4t9vtfx5p61wm0000gp/T/tinygo3346914303/main` Caused by: 0: failed...

I tried reviewing this, but there's too much compiler stuff I don't yet understand. Can we put this behind a flag temporarily so that it can be merged and allow...

Yes. We can review it and test it more thoroughly without holding up other PRs and without creating large merge conflicts. Glad to hear Darwin support is possible.

@aykevl My goal with the `merge but with flag to enable` was to allow this to unblock other patches (as you said above) and give people the opportunity to test...

My suggestion is to run the test corpus, removing all the `purego` and `noasm` tags. If that passes, we can merge this and debug any issues as they come up.

@dkegel-fastly You have a linux box. You want to take a look at running these tests?

Pretty sure that test shouldn't be hitting a stack overflow. The assembly version of the code is a few instructions and a table lookup. Edit: oh, saw the stack overflow...

I'm always so pleased when testing reveals bugs :D