Damien Grisonnet

icon indicating an email [email protected]

icon company Red Hat icon location Paris, France icon location Senior Software Engineer at Red Hat

Results 522 comments of Damien Grisonnet

Metrics Server Long term plan

/cc @olivierlemasle

Fix broken links in README.md

Sorry I missed this PR. Thank you for sending the fix @sillyfrog, would you mind squashing the commits into one?

Fix broken links in README.md

Thanks! /lgtm /approve

Update deployment manifests and instructions

This was fixed by https://github.com/kubernetes-sigs/prometheus-adapter/pull/531.

Insecure cipher suites exposed resulting in SWEET32 vulnerability

I would follow the same train of though with Kubernetes in the issue that was linked above. I don't think we should maintain our own list of cipher suites, but...

Support secondary custom-metric-server

This is a feature that would be very useful, but it shouldn't be done at the prometheus-adapter level since we don't have the resources today to invest into that. As...

Fix for CVE-2022-1996 (Score: 9.1)

This is a false positive from a transitive dependency that is not using the functionality that is impacted by the CVE, so there is no need to fix it for...

Set non zero query parameter for end in series query API

@srinidhis94 will you have some time to finish this work? It seems to be waiting to be rebased and the tests need to be fixed

GKE Private Cluster "v1beta1.custom.metrics.k8s.io" Apiservice showing (FailedDiscoveryCheck) "net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)""

The log line means that the kube-apiserver couldn't reach prometheus-adapter. Have you perhaps checked if the solution mentioned above works for you?

GKE Private Cluster "v1beta1.custom.metrics.k8s.io" Apiservice showing (FailedDiscoveryCheck) "net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)""

You are welcome. For anyone stumbling upon this issue in the future, solution has been provided in https://github.com/kubernetes-sigs/prometheus-adapter/issues/534#issuecomment-1290762676.