Damien Grisonnet
Damien Grisonnet
Oh that's nice I wasn't aware that this was possible :open_mouth: Kudos for that :+1:
We can always fix it if it doesn't work well on the first attempt. I was diving a bit in the doc out of curiosity, and it is kind of...
Sounds good, I was the one who told David to assign you, we can just put it as help-wanted since no one as time to fix that right now. /unassign...
> @dgrisonnet out of interest, does Prow ever remove the ok-to-test label? Off topic but there is an argument that code from un-verified sources should need to be approved each...
> Prow effectively has the same abuse mechanism, once a minor docs change has been flagged as ok-to-test the submitter can modify their code to run arbitrary actions via any...
/remove-lifecycle stale
I commented about this in https://github.com/kubernetes/kube-state-metrics/issues/1832#issuecomment-1322518103. I am not in favor of this change since it is already possible to add labels and annotations metrics via the custom resource configuration....
Awesome, great stuff @rexagod! /lgtm /approve /unhold
/triage accepted /assign @Richabanker
/remove-lifecycle rotten