Dan Greene

Results 109 comments of Dan Greene

**Possible solution:** For me, the reason why I couldn't hit the correct line was due to sourcemaps being incorrect/absent due to an issue with `ts-jest` when Jest's `collectCoverage` option was...

Yes, whatever keyboard key we choose (space works for me) we need to give it tabIndex. would a PR be accepted for this?

@Rall3n I agree to the spec but it’s just sad for the user that it’s a bit confusing. I concede though because following specs allows us to provide a common...

On second thought, @Rall3n i just re-read [the combo box authoring spec](https://www.w3.org/WAI/ARIA/apg/patterns/combobox/) and it refers to the popup button or children of the popup. The clear button is neither of...

The solution of using the setting solved the issue for me. I'd nominate that this issue be closed.

Thanks for the detailed report. The team and I are on vacation for at least a week. But they’ll look at it when we get back. If you are willing...

@yhy-1 do you know if a fix for this is planned?

If you can solve it and make a PR, we’d love the help.

I think the approach we’d most likely be willing to accept is a custom type assertion since it’s my belief that a custom type assertion would provide the same runtime...

I’m sorry that I can’t help. I did the best I was capable of when I wrote the original PR the code that you’re looking at.