Dhruv Govil

Results 186 comments of Dhruv Govil

A related issue is that we only need Zlib to build on Windows. Does this affect your PR at all? https://github.com/PixarAnimationStudios/OpenUSD/pull/2988

Would you only need to support static builds on Windows? Or would you need to support them on Linux and Mac too, where the OS vends it?

Okay. Just a few more questions: 1.If I understand the change correctly, this would make it always statically linked. I think many of us would still prefer to use dynamic...

I think this would need to be an option perhaps? I don't agree with the approach of making this a default as I think being dynamically provided by the OS...

1.39 isn't yet officially released, and I don't believe there's been any work to integrate it with USD yet. It has fairly significant changes so I don't expect it to...

The first point is due to this https://github.com/PixarAnimationStudios/OpenUSD/issues/3100 afaik

@jstone-lucasfilm Just my 2c, but I think it would be better to incorporate these changes into @ld-kerley 's existing PR since it has precedence and there's a longer tail of...

Related issue https://github.com/PixarAnimationStudios/OpenUSD/issues/2438 I assume this is a running in a Docker image? I do think based on that change it should be fixed now, but I don't have a...

Okay, I just confirmed that commit did fix the issue. @ysinh can you verify that everything works on your end as well?