Dhruv Govil

Results 186 comments of Dhruv Govil

Yep, agreed. I'll try and come up with suitable language for the doc to strengthen that recommendation

I'm thinking a reasonable check right now might be: - Is a string attribute - Is not a primvar or an input/output I think that would cover most of the...

Just pinging this thread again, do the changes in my previous message sound reasonable? I can update the PR accordingly?

@nvmkuruc and @spiffmon I added validation functions and parameters in the code to check if something can be localized. CanLocalize(attribute) -> Checks if its a string attribute and if its...

Okay that's fair. I updated it so it keeps the `default` schema name in the attribute name. Regarding making the default easier to make, I just set the default token...

Also changed the localization attribute for default language to include the instance name too, but I disallow creation from other instance names than `default`, and fetching the attribute will always...

@spiffmon if you're re-running usdGenSchema in your automation, how are you getting around needing extra headers in the cpp file? e.g I need `primvars.h`to check if its a primvar, but...

Anyway, made the change by adding `CreateDefaultAPI` and `ApplyDefaultAPI` methods on both schemas. So now re-running the usdGenSchema doesn't cause any changes. I haven't added any Python bindings for the...

Ah that's good to know. I changed that over. I'll probably make a separate PR down the road for the schema gen to allow for a section in the `.cpp`...

Not so much insufficient as it feels odd to have includes not at the top of the file? I know USD doesn’t have a style guide but it feels like...