Daniel Helm

Results 8 comments of Daniel Helm

I have read the CLA Document and I hereby sign the CLA

Hi @bschorchit -- thanks for tagging the issue. As a new contributor to MetaMask, I'm unsure of the process at this point. Is there anything I can do to help...

Excited to have a review, but when I went to pull in the `develop` branch, I guess there are changes that have broken my implementation -- new view: ![image](https://github.com/MetaMask/metamask-extension/assets/4205837/a6a3f4ce-3d0b-45c9-8c22-7498a815053a) I'll...

Okay, I started to make minimal changes, but the last PR for Op Bedrock support seems to be pretty regressive for legacy txs. Here's what a legacy tx currently looks...

A number of updates made to adjust for the new UI changes. Fixes: - in type2 transactions, Total gas now includes L1 & L2 fees. Changes: - renamed "Optimism Fee"...

New push to resolve merge conflicts (updating for Op Sepolia testnet support). @bschorchit please let me know if there's anything else on my end to keep an eye on with...

> Upon reviewing this PR, I noticed only minor differences compared to the Optimism flow. Therefore, I will be preparing the upcoming PRs for Scroll, and your initial PR will...

Update: addition of Scroll to the new Transaction Controller behavior is implemented in #23991