David Garske comments

Results 356 comments of


                                            David Garske

Support for KDF counter and feedback modes with HMAC

Looks good to me, but haven't tested. @SparkiDev will you please review and provide feedback?

[Bug]: ClientHello's status_request extension handling issue

@anhu or @ejohnstown any update on this?

[Ada] Initial library support

Hi @Irvise , Thank for the pull request. I will look it over and I also pinged Joakim. I don't see a contrubutor agreement on file. Would you mind submitting...

[Ada] Initial library support

@joakim-strandberg any feedback on this? Seems like a nice Ada feature having wolfSSL as a library.

[Ada] Initial library support

Hi @Irvise , what is the current state for this PR? Could you please rebase to latest master. I think that may help resolve some of the CI issues reported....

[Ada] Initial library support

FYI: @Irvise , we have merged #7397. Looking forward to your continued work on this. Thank you, David Garske, wolfSSL

make "yes;no" cmake options boolean instead of string

Okay to test. Contributor agreement on file. Thank you @oltolm . Changes look great!

make "yes;no" cmake options boolean instead of string

Retest this please

make "yes;no" cmake options boolean instead of string

> Those options that are still "yes" or "no" are not boolean. For example `WOLFSSL_AESGCM` is defined like this > > ``` > add_option("WOLFSSL_AESGCM" > "Enable wolfSSL AES-GCM support (default:...

Fix compilation issues when using PKA=1 for i.MX RT targets

Contributor agreement on file. Changes look good to me. Do you know if PKA supported on all the i.MX RT targets? Maybe we should add another CI test for these?...